Fix GroupMetadata backwards compatibility
#2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I manually downloaded these wheels and ran the Vector Search unit tests with them and they passed. |
Good news! |
nguyenv
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #2085 broke backwards compatibility for
GroupMetadata. This PR fixes that issue. To prevent similar issues in the future, a test that reads aGroupwritten with TileDB-Py 0.32.3 and verifies that all metadata values and types are as expected has been added.Additionally, a test has been added to demonstrate the new types, following the supported types of
Arraymetadata.Temporary wheels: https://github.com/TileDB-Inc/TileDB-Py/actions/runs/11525100400
cc. @jparismorgan